Tim Barcz

Code Review like the Mafia

We're a growing software development company.  As we're growing in numbers we're finding that we have to implement a more formal process for code reviews.  In the past we could just look over each other's shoulders and give a nod.  It's just not feasible to do that anymore given the growth we've had. 

The code review process can be tricky in that you have to be clear with everyone going in that a review of code is simply in the best interest of the company and that anything said shouldn't be said or taken personally.  Being one who places a lot of pride in my work, I fight the urge to defend my code/design.  I'm trying to live by the following summation of how to code review:


In the television drama The Sopranos there are frequent arguments between characters.  No matter how much arguing, fighting, or threats, the characters almost always are friends right after.  Business is business, nothing that is said during an argument sticks or lasts too long.

Maybe it's a bit utopian to think that we could code review like that, not having to fear/worry about people's feelings during the review and knowing that no matter what was said we could go grab lunch together afterwards.  Again, pointing the finger squarely at myself, is it reasonable to be pummeled in a meeting about your work and not take it personally or get worked up?  For me that's a tough one that I'm going to have to work on, I mean let's face it, I'm not part of the mafia.